[T2] Refactor Group 9z: Compression #3393
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2026
Closed
veblush
force-pushed
the
t2-9z
branch
2 times, most recently
from
67b0cd3 to
c1a7361
Compare
Refactor t2-11z Refactor t2-19z Refactor t2-7z
veblush
force-pushed
the
t2-9z
branch
2 times, most recently
from
cbb79ad to
57fcbbe
Compare
ddavis-2015
reviewed
Feb 2, 2026
Member
ddavis-2015
left a comment
ddavis-2015
left a comment
There was a problem hiding this comment.
I'm really liking these new ASSERT_ macros 👍
| int* output_dims_data, const float* expected_output_data, | ||
| TfLiteConvParams* conv_params, TFLMRegistration registration, | ||
| float* output_data | ||
| void ValidateConvFails(TfLiteTensor* tensors, int tensors_size, |
Member
There was a problem hiding this comment.
Perhaps this should be ValidateConvFailsDuringPrepare to be very specific about where the failure is expected to occur.
|
|
||
| #endif // USE_TFLM_COMPRESSION | ||
|
|
||
| void ValidateDepthwiseConvFails(int tensors_size, TfLiteTensor* tensors, |
Member
There was a problem hiding this comment.
Perhaps ValidateDepthwiseConvFailsDuringPrepare to be more concise as to what failure to expect?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG=n/a