Conversation
54145a
changed the title
sylirre
suggested changes
Jul 21, 2025
Member
sylirre
left a comment
sylirre
left a comment
There was a problem hiding this comment.
Changes for docs are ok. For the source code files see suggestions below.
src/cli/proot.h
Outdated
| .subtitle = "chroot, mount --bind, and binfmt_misc without privilege/setup", | ||
| .synopsis = "proot [option] ... [command]", | ||
| .colophon = "Visit http://proot.me for help, bug reports, suggestions, patchs, ...\n\ | ||
| .colophon = "Visit https://proot-me.github.io for help, bug reports, suggestions, patchs, ...\n\ |
Member
There was a problem hiding this comment.
This link should be changed to https://github.com/termux/proot
Termux proot differs from https://github.com/proot-me/proot
| note(tracee, INFO, USER, | ||
| "Get a 64-bit version that supports 32-bit binaries here: " | ||
| "http://static.proot.me/proot-x86_64"); | ||
| "https://proot-me.github.io/"); |
Member
There was a problem hiding this comment.
This technically is not correct at all.
Proot compatible with Termux can be obtained only with pkg install proot.
Author
There was a problem hiding this comment.
Actually I don't think this message will ever be shown if proot's installed from pkg, as pkg will take care of architecture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated help links which are now leading to NSFW contents.