fix: exact match should check key as path segment#65
Merged
jackieli-tes merged 2 commits intomainfrom Mar 11, 2026
Merged
Conversation
listObjects uses MinIO prefix matching, so key "foo" also returns "foo-bar/cache.tzst". The previous fix (PR #60) used startsWith(key) which still has the same problem. Use startsWith(key + "/") to ensure the key matches as a full path segment. Add a workflow test that saves a decoy cache with a longer key sharing the same prefix, then verifies exact restore does not match it.
On Windows, path.join produces backslash separators, so MinIO objects have "\" in their names. The exact match check must use path.sep to match the platform's separator.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findObject— usesstartsWith(key + "/")instead ofstartsWith(key)to ensure the cache key matches as a full path segment, not just a string prefixstartsWith(key)still has the prefix-matching bug)Context
Objects are stored as
{key}/{cacheFileName}(e.g.my-cache/cache.tzst). MinIO'slistObjectsV2returns all objects with a matching string prefix, so queryingmy-cachealso returnsmy-cache-v2/cache.tzst. CheckingstartsWith(key + "/")ensures only objects under the exact key directory match.Test plan
test-exact-matchworkflow passes — decoy cache is not matched by exact restoretest,test-env,lookup-onlyworkflows still passbuildworkflow confirms dist/ is up to date