-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Move version info. to appropriate ALTO element #4464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "\t\t\t<ocrProcessingStep>\n" | ||
| "\t\t\t\t<processingSoftware>\n" | ||
| "\t\t\t\t\t<softwareName>tesseract "); | ||
| "\t\t\t\t\t<softwareName>Tesseract</softwareName>\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you replace "tesseract" by "Tesseract"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Stefan, thanks for your review :)
I took direction from the end-user documentation, such as the README and user manual, which generally capitalize the name (at least when referring to the software as a whole and not simply the executable), as is usually the case for proper nouns.
I thought perhaps the lowercasing here might have been due to the previous developer conflating those two things (as commonly happens), or was perhaps following a stylistic choice that was prevalent at the time but which no longer appears to be the case (based on the current documentation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some examples from other existing software:
<OCRProcessing ID="IdOcr">
<ocrProcessingStep>
<processingDateTime>2018-12-21</processingDateTime>
<processingSoftware>
<softwareCreator>ABBYY</softwareCreator>
<softwareName>ABBYY FineReader Engine</softwareName>
<softwareVersion>11</softwareVersion>
</processingSoftware>
</ocrProcessingStep>
</OCRProcessing>
<Processing ID="ocrd-tesserocr-recognize-0">
<processingStepDescription>layout/segmentation/region</processingStepDescription>
<processingStepSettings>
{"find_tables": "True", "model": "deu_latf", "segmentation_level": "region", "textequiv_level": "word", "dpi": "0", "padding": "0", "overwrite_segments": "False", "overwrite_text": "True", "shrink_polygons": "False", "block_polygons": "False", "find_staves": "False", "sparse_text": "False", "raw_lines": "False", "char_whitelist": "", "char_blacklist": "", "char_unblacklist": "", "tesseract_parameters": "{}", "xpath_parameters": "{}", "xpath_model": "{}", "auto_model": "False", "oem": "DEFAULT"}
</processingStepSettings>
<processingDateTime>2024-10-11T17:27:18.287674</processingDateTime>
<processingSoftware>
<softwareName>ocrd-tesserocr-recognize</softwareName>
</processingSoftware>
</Processing>
And my local chatbot suggests this for Tesseract:
<OCRProcessing ID="proc_001">
<ocrProcessingStep>
<processingDateTime>2024-01-15T14:30:00</processingDateTime>
<processingStepDescription>OCR processing with Tesseract</processingStepDescription>
<processingSoftware>
<softwareCreator>Google</softwareCreator>
<softwareName>Tesseract</softwareName>
<softwareVersion>5.3.0</softwareVersion>
<applicationDescription>Open Source OCR Engine</applicationDescription>
</processingSoftware>
<settings>
<setting name="language" value="eng+deu"/>
<setting name="psm" value="6"/>
<setting name="dpi" value="300"/>
<setting name="confidence_threshold" value="50"/>
</settings>
</ocrProcessingStep>
</OCRProcessing>
Maybe some of these suggestions would be really nice and helpful for the existing Tesseract code.
stweil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
It's currently bundled in with the
softwareNameelement even though there's a specificsoftwareVersionelement for it, and I could find no reason for this given in the code or commit history. Separating these pieces of information makes them easier to parse programmatically.