Open
Conversation
TheCSharpAcademy
requested changes
Nov 1, 2025
Collaborator
TheCSharpAcademy
left a comment
TheCSharpAcademy
left a comment
There was a problem hiding this comment.
@Lepros311 I spent sometime trying to build the app and found a few problems:
- Currently during migration It doesn't build due to FK conflicts in the seed data when the database is being first built. And If I fix the migration and run it, the second time around it does this:
- There seems to be a mismatch between your types in angular and C#, which is causing a 400 (due to the validation of the price field):
Author
|
I just finished fixing the project and pushed it again.
…On Sat, Nov 1, 2025 at 2:41 AM The C# Academy ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@Lepros311 <https://github.com/Lepros311> I spent sometime trying to
build the app and found a few problems:
- Currently during migration It doesn't build due to FK conflicts in
the seed data when the database is being first built. And If I fix the
migration and run it, the second time around it does this:
image.png (view on web)
<https://github.com/user-attachments/assets/bd27c365-705f-49e5-a19f-890e4850a302>
- There seems to be a mismatch between your types in angular and C#,
which is causing a 400 (due to the validation of the price field):
image.png (view on web)
<https://github.com/user-attachments/assets/2ec13d91-de07-494c-afce-1dde23af3b1c> image.png
(view on web)
<https://github.com/user-attachments/assets/89470aa7-f773-42d8-ae77-ff84ba512165>
—
Reply to this email directly, view it on GitHub
<#13 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APV3C4RIXGZZ3JHR5NJFCBL32RI2DAVCNFSM6AAAAACKMCHMZ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIMBWHEYDKMZVGA>
.
You are receiving this because you were mentioned.Message ID:
<TheCSharpAcademy/CodeReviews.Angular.
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.