Document Processor Submission - Post completion#72
Document Processor Submission - Post completion#72JJHH17 wants to merge 42 commits intothe-csharp-academy:mainfrom
Conversation
Added initial README with project overview.
Expanded README.md to include detailed project overview, usage steps, and file import/export instructions.
Added information about automated file export using CRONOS package.
chrisjamiecarter
left a comment
chrisjamiecarter
left a comment
There was a problem hiding this comment.
Hey @JJHH17 👋,
Excellent work on your Document Processor project submission 🎉!
I have performed a peer review. Review/ignore any comments as you wish.
⭐ Fantastic project, great job. One thing to note is that in C# we follow Pascal Case conventions where acronyms are treated as words (e.g., XmlReader, HttpClient - not XMLReader, HTTPClient), making code more readable and consistent with the framework's style guidelines. You used CSV, PDF, XLSX, etc...
🟢 Requirements
⭐ You have fulfilled all of the project requirements!
I will go ahead and mark as approved, keep up the excellent work on the next projects! 😊
Best regards,
@chrisjamiecarter 👍
| public string PhoneNumber { get; set; } | ||
| } | ||
|
|
||
| public class PhoneBookContext : DbContext |
There was a problem hiding this comment.
🟠 Separate Class
💡 This is not a Model, it is a DbContext. Move it to a different location that makes sense logically.
|
|
||
| namespace DocumentProcessor.JJHH17.ScheduledExport; | ||
|
|
||
| public class ScheduledExport |
| using var host = builder.Build(); | ||
| var runHost = host.RunAsync(); | ||
|
|
||
| var uiCts = new CancellationTokenSource(); |
There was a problem hiding this comment.
🟠 Variable Naming
❓ What is this abomination of a variable name 😆
| var uiCts = new CancellationTokenSource(); | |
| var cancellationSource = new CancellationTokenSource(); |
2 participants
This project: