chore: faster eqn. reasoning in Displayed#590
Merged
Conversation
Member
Author
|
attn @jajaperson |
Member
Changed pages
|
ncfavier
reviewed
Jan 28, 2026
Contributor
|
Looks great! Thanks for doing this |
plt-amy
force-pushed
the
aliao/total-eqn-reasoning
branch
from
d5c549e to
c01ee18
Compare
plt-amy
force-pushed
the
aliao/total-eqn-reasoning
branch
from
c01ee18 to
e49a16e
Compare
plt-amy
force-pushed
the
aliao/total-eqn-reasoning
branch
from
e49a16e to
0d4967d
Compare
TOTBWF
approved these changes
Feb 25, 2026
Collaborator
TOTBWF
left a comment
TOTBWF
left a comment
There was a problem hiding this comment.
Looks good, happy to see this performance nightmare solved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #463 in a more direct way than #505, with a bespoke set of operators for equational reasoning in
PathP (λ i → Hom[ p i ] ...) ...that take the "continuation" in the form of a path inΣ _ λ m → Hom[ m ] x y. This does mean that we still need all the[]versions of the category combinators, but it's an improvement, at least, and does not complicate the dependency graph.