Enable Override of EBS Region, AZ, & Endpoint Props#518
Open
akutz wants to merge 1 commit intothecodeteam:masterfrom
Open
Enable Override of EBS Region, AZ, & Endpoint Props#518akutz wants to merge 1 commit intothecodeteam:masterfrom
akutz wants to merge 1 commit intothecodeteam:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
======================================
Coverage 28.4% 28.4%
======================================
Files 34 34
Lines 2003 2003
======================================
Hits 569 569
Misses 1373 1373
Partials 61 61Continue to review full report at Codecov.
|
codenrhoden
reviewed
Apr 25, 2017
Contributor
codenrhoden
left a comment
codenrhoden
left a comment
There was a problem hiding this comment.
Looks good at first glance. Definitely want to hear it works from @shamimgeek. This will be a nice way to pick up eucalyptus support!
akutz
force-pushed
the
feature/ebs-important-az-region
branch
2 times, most recently
from
f33269e to
46ac91c
Compare
This patch introduces the ability for the EBS driver to override the client's provide region, availability zone, and endpoint properties by specifying them in the server-side config with a suffix of !important (like CSS).
akutz
force-pushed
the
feature/ebs-important-az-region
branch
from
46ac91c to
7f6a15d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces the ability for the EBS driver to override the client's provided region, availability zone, and endpoint properties by specifying them in the server-side config with a suffix of !important (like CSS).
Many thanks to libStorage & REX-Ray community member @shamimgeek for discovering this! Thanks Shamim!