Add AutoYaST and Autoinstall provisioning templates#4892
Open
maximiliankolb wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
Needs tech review
maximiliankolb
force-pushed
the
autoyast_and_autoinstall_templates
branch
from
7840143 to
cd71b65
Compare
Lennonka
reviewed
Jun 2, 2026
Contributor
Lennonka
left a comment
Lennonka
left a comment
There was a problem hiding this comment.
Overall LGTM, just a few nitpicks.
This patch adds AutoYaST templates for SLES 15 and below, and Preseed Autoinstall templates for Ubuntu 20.04 and above. The "Preseed default" template in foreman for "develop" does not contain the "puppet_setup" snippet: $ rg --files-with-matches "puppet_setup" | sort -u The "puppetlabs_repo" snippet is not included in any default provisioning templates for SLES (only cloud init-based templates): $ rg --files-with-matches "puppetlabs_repo" | sort -u New custom provisioning snippet for Ubuntu that uses "Preseed Autoinstall" templates compared to "Preseed" for Debian: $ cp -i guides/common/modules/ref_custom-provisioning-snippet-example-for-debian.adoc guides/common/modules/ref_custom-provisioning-snippet-example-for-ubuntu.adoc
maximiliankolb
force-pushed
the
autoyast_and_autoinstall_templates
branch
from
cd71b65 to
16b1da3
Compare
pr-processor
Bot
added
Needs re-review
and removed
Waiting on contributor
maximiliankolb
commented
Jun 3, 2026
Contributor
Author
maximiliankolb
left a comment
maximiliankolb
left a comment
There was a problem hiding this comment.
I applied some feedback and double checked other suggestions which I did not apply based on my findings in foreman.
Ready for re-review.
Lennonka
added
style review done
Contributor
Author
|
@Thorben-D Can you please review my PR? |
Thorben-D
approved these changes
Jun 8, 2026
Thorben-D
left a comment
Thorben-D
left a comment
There was a problem hiding this comment.
Tech review ✅
Looks good to me too. Quite the improvement style wise!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
This patch adds AutoYaST templates for SLES 15 and below, and Preseed Autoinstall templates for Ubuntu 20.04 and above.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
The "Preseed default" template in foreman for "develop" does not contain the "puppet_setup" snippet:
$ rg --files-with-matches "puppet_setup" | sort -uThe "puppetlabs_repo" snippet is not included in any default provisioning templates for SLES (only cloud init-based templates):
$ rg --files-with-matches "puppetlabs_repo" | sort -uNew custom provisioning snippet for Ubuntu that uses "Preseed Autoinstall" templates compared to "Preseed" for Debian:
$ cp -i guides/common/modules/ref_custom-provisioning-snippet-example-for-debian.adoc guides/common/modules/ref_custom-provisioning-snippet-example-for-ubuntu.adocContributor checklists
Please cherry-pick my commits into: