Include one more level in toc#4898
Open
adamruzicka wants to merge 1 commit into
Open
Conversation
Recently, some heading were pushed to a lower level, making them disappear from the TOC.
|
The PR preview for be57fae is available at theforeman-foreman-documentation-preview-pr-4898.surge.sh No diff compared to the current base |
Lennonka
approved these changes
Jun 3, 2026
Contributor
Lennonka
left a comment
There was a problem hiding this comment.
Thank you, Adam, LGTM.
Should we cherry pick this to earlier branches down to 3.16 if we want to have the check on all those branches?
I would prefer to have it on all those branches in case we need to create PRs on them. It doesn't happen that often, we mostly cherry pick from master. But it would be good to have it just in case.
Contributor
Author
|
Yes, it should be picked everywhere where we may need the link checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Including one more level of heading in TOC.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Recently, some heading were pushed to a lower level, making them disappear from the TOC.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Extracted from #4809
Contributor checklists
Please cherry-pick my commits into: