Skip to content

Move an actionable step from assembly intro to a module#4904

Merged
aneta-petrova merged 1 commit into
theforeman:masterfrom
aneta-petrova:cqa-admin
Jun 8, 2026
Merged

Move an actionable step from assembly intro to a module#4904
aneta-petrova merged 1 commit into
theforeman:masterfrom
aneta-petrova:cqa-admin

Conversation

@aneta-petrova

@aneta-petrova aneta-petrova commented Jun 3, 2026

Copy link
Copy Markdown
Member

What changes are you introducing?

Making sure the assembly for migrating to external DB does not contain steps.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

This is part of the requirements for Content Quality Assessment (CQA).

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

This is the last change I want to make to address CQA's modularization requirements. It's only a single change because I've fixed up other things in other PRs already.

Assisted-by: Cursor

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.19/Katello 4.21
  • Foreman 3.18/Katello 4.20 (Satellite 6.19)
  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6, 7.7, and 7.8)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

@github-actions github-actions Bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Jun 3, 2026
@aneta-petrova aneta-petrova removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Jun 3, 2026
@aneta-petrova aneta-petrova changed the title Review Administering for modularization Move an actionable step from assembly intro to a module Jun 3, 2026

@Lennonka Lennonka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Jun 5, 2026
@aneta-petrova aneta-petrova merged commit d7e2710 into theforeman:master Jun 8, 2026
12 checks passed
@aneta-petrova aneta-petrova deleted the cqa-admin branch June 8, 2026 15:56
aneta-petrova added a commit that referenced this pull request Jun 8, 2026
Assisted-by: Cursor
(cherry picked from commit d7e2710)
aneta-petrova added a commit that referenced this pull request Jun 8, 2026
Assisted-by: Cursor
(cherry picked from commit d7e2710)
aneta-petrova added a commit that referenced this pull request Jun 8, 2026
Assisted-by: Cursor
(cherry picked from commit d7e2710)
aneta-petrova added a commit that referenced this pull request Jun 8, 2026
Assisted-by: Cursor
(cherry picked from commit d7e2710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

style review done No issues from docs style/grammar perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants