Fixes #39366 - deprecate Loader component and use PF5 spinner instead#11006
Merged
Conversation
andreilakatos
force-pushed
the
update-loader-to-pf5
branch
from
2ee4999 to
ba2708f
Compare
Lukshio
requested changes
May 29, 2026
Lukshio
left a comment
Lukshio
left a comment
Contributor
There was a problem hiding this comment.
Please update tests to RTL - check if component is rendered correctly for multiple sizes
andreilakatos
force-pushed
the
update-loader-to-pf5
branch
from
ba2708f to
7780eb7
Compare
Contributor
Author
Done, had to use sm instead of xs. xs no longer exists for pf5 spinner 🫤 |
andreilakatos
force-pushed
the
update-loader-to-pf5
branch
4 times, most recently
from
d0aecf4 to
4bc7b33
Compare
andreilakatos
changed the title
Contributor
Author
Didn't know where to check these components for sure. So I just rendered them side by side for a comparison. Screen.Recording.2026-06-03.at.19.44.14.mov |
Lukshio
requested changes
Jun 4, 2026
pr-processor
Bot
added
Waiting on contributor
Needs re-review
and removed
Needs re-review
Waiting on contributor
labels
andreilakatos
force-pushed
the
update-loader-to-pf5
branch
3 times, most recently
from
3eb3b1a to
61e6e06
Compare
Lukshio
reviewed
Jun 8, 2026
Lukshio
left a comment
Lukshio
left a comment
Contributor
There was a problem hiding this comment.
@andreilakatos changes looks good, you can squash the commits. QE testing will be required.
andreilakatos
force-pushed
the
update-loader-to-pf5
branch
from
61e6e06 to
9bcbce9
Compare
Lukshio
requested changes
Jun 8, 2026
andreilakatos
force-pushed
the
update-loader-to-pf5
branch
from
9bcbce9 to
7b05cd4
Compare
Lukshio
approved these changes
Jun 10, 2026
Contributor
|
Thanks @andreilakatos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deprecates the shared
Loadercomponent.Use @patternfly/react-core Spinner component in these files instead of the loader
webpack/assets/javascripts/react_app/components/ChartBox/ChartBox.js
webpack/assets/javascripts/react_app/components/common/forms/Actions.js
webpack/assets/javascripts/react_app/components/hosts/powerStatus/PowerStatus.js
webpack/assets/javascripts/react_app/components/ForemanModal/subcomponents/SubmitOrCancel/SubmitBtn.js
Purpose
Foreman is moving table and layout code to PatternFly 5. The shared
Loaderstill used patternfly-react (PF3), which produced inconsistent styling and duplicated spinner implementations. This PR updates that shared loader so pending states use the same PF5SpinnerasLoadingPage,TableIndexPage, and other PF4/PF5 surfaces.