Skip to content

Fixes #39403 - Moved all reusable logic from AreaChartLegend.js to .../helpers/LegendHelpers.js#11010

Merged
Lukshio merged 1 commit into
theforeman:developfrom
tlabaj:legend_helpers
Jun 8, 2026
Merged

Fixes #39403 - Moved all reusable logic from AreaChartLegend.js to .../helpers/LegendHelpers.js#11010
Lukshio merged 1 commit into
theforeman:developfrom
tlabaj:legend_helpers

Conversation

@tlabaj

@tlabaj tlabaj commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Moved all reusable logic from AreaChartLegend.js to charts/helpers/LegendHelpers.js

These helpers will also be used by the line chart in Openscap.

@Lukshio Lukshio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create please new Redmine issue and update the commit message, changes looks good, needs testing.

@tlabaj tlabaj changed the title Moved all reusable logic from AreaChartLegend.js to .../helpers/LegendHelpers.js Fixes #39403 - Moved all reusable logic from AreaChartLegend.js to .../helpers/LegendHelpers.js Jun 8, 2026

@Lukshio Lukshio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packit tested + manually verified. Thanks @tlabaj

@Lukshio Lukshio merged commit 3d7239b into theforeman:develop Jun 8, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants