Skip to content

Fixes #39261 - Pin theforeman-rubocop in Gemfile only #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stejskalleos merged 1 commit into from
Apr 29, 2026
Merged

Fixes #39261 - Pin theforeman-rubocop in Gemfile only #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

source 'http://rubygems.org'

gem 'theforeman-rubocop', '~> 0.1.0.pre', groups: %i[development rubocop]

gemspec

gem 'theforeman-rubocop', '~> 0.1.2', groups: %i[development rubocop]
2 changes: 0 additions & 2 deletions foreman_bootdisk.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,4 @@ Gem::Specification.new do |s|
['package.json']

s.required_ruby_version = '>= 2.7', '< 4'

s.add_development_dependency 'theforeman-rubocop'
Copy link
Copy Markdown
Collaborator

@stejskalleos stejskalleos Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against the change, but what's the reasoning here?
Is this causing an issue, or is it just a best practice?

Copy link
Copy Markdown
Member Author

@ofedoren ofedoren Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ehh, sorry I didn't write it here as well, but the idea is here:

theforeman/foreman_ansible#789 (comment)

end
Loading