Add Templates feature to foreman-proxy#519
Open
shubhamsg199 wants to merge 1 commit into
Open
Conversation
shubhamsg199
force-pushed
the
templates-feature
branch
from
dcadf66 to
9a7993c
Compare
ehelms
reviewed
May 26, 2026
| parameter: --bmc-redfish-verify-ssl | ||
| help: Verify SSL certificates for Redfish BMC connections. | ||
| type: Boolean | ||
| foreman_proxy_templates_listen_on: |
Member
There was a problem hiding this comment.
We are using templates and template which is confusing to as a user, let's pick one and be consistent. I also wonder if we should lean into using the word "provisioning" here as I have heard users be confused about the kind of templates that are used throughout Foreman.
Contributor
Author
There was a problem hiding this comment.
Do you mean tighten the help text to say something like provisioning templates everywhere or adjust flag naming altogether?
shubhamsg199
force-pushed
the
templates-feature
branch
3 times, most recently
from
77b2cc9 to
6be7b5b
Compare
stejskalleos
requested changes
Jun 8, 2026
| --add-feature google \ | ||
| --add-feature remote-execution \ | ||
| --add-feature bmc \ | ||
| --add-feature templates \ |
Contributor
There was a problem hiding this comment.
Can we add --templates-listen-on & --templates-url to the test as well?
Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
shubhamsg199
force-pushed
the
templates-feature
branch
from
6be7b5b to
26ddc10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
What are the changes introduced in this pull request?
How to test this pull request
Steps to reproduce:
Checklist