Add KEA DHCP provider feature for foreman-proxy by archanaserver · Pull Request #531 · theforeman/foremanctl

archanaserver · 2026-06-01T09:18:28Z

Why are you introducing these changes? (Problem description, related links)

ISC DHCP reached end-of-life in October 2022 and has been removed from RHEL 10. This adds support for KEA DHCP as the replacement.

What are the changes introduced in this pull request?

Add dhcp-kea-external feature definition to src/features.yaml
Create Smart Proxy configuration template dhcp_kea_api.yml.j2
Add default Ansible variables for KEA server connection (localhost:8000, default subnet)
Add integration tests for DHCP KEA feature validation

How to test this pull request

Steps to reproduce:

Verify feature is available: ./foremanctl features | grep dhcp-kea-external
Deploy with KEA DHCP feature enabled: ./foremanctl deploy --add-feature dhcp-kea-external
Verify feature is enabled: ./foremanctl features --list-enabled | grep dhcp-kea-external
Check configuration file was created: podman exec foreman-proxy ls -la /etc/foreman-proxy/settings.d/dhcp_kea_api.yml
Run tests python -m pytest tests/foreman_proxy_test.py::test_dhcp_kea_feature_present -v

Checklist

Tests added/updated (if applicable)
Documentation updated (if applicable)

Adds the dhcp-kea-external feature to enable Smart Proxy integration with external KEA DHCP servers.

evgeni · 2026-06-01T09:30:11Z

  description: Power management for bare metal hosts (IPMI, Redfish)
  foreman_proxy:
    plugin_name: bmc
+dhcp-kea-external:


I think the feature should be "dhcp" and then you add a parameter to select which provider to use, with kea being one of the answers

makes way more sense to have a single dhcp feature with a provider parameter

I played with that thought in #532 for the DNS side of things, would love to hear your opinion on the approach I took

evgeni · 2026-06-01T09:31:41Z

 foreman_proxy_bmc_redfish_verify_ssl: true
+
+# KEA DHCP settings (external unmanaged server)
+foreman_proxy_dhcp_kea_server: localhost


What are the chances that localhost is a place where a Kea will actually run (outside of development setups)?

I think we should leave that undef (like in https://github.com/theforeman/foremanctl/pull/523/changes) and force the user to set a sensible value.

evgeni · 2026-06-01T09:35:52Z

+
+:enabled: {{ feature_enabled }}
+:use_provider: dhcp_kea_api
+:server: {{ foreman_proxy_dhcp_kea_server }}


where does this come from? I don't see such an option in https://gitlab.surrey.ac.uk/sm0049/smart-proxy-dhcp-kea-api/

yeah, i was just playing around with few things, needed to look again, the reason i added that in draft but thanks for reviews, also i tryna fix few things with the updated changes.

evgeni · 2026-06-01T09:36:04Z

+:enabled: {{ feature_enabled }}
+:use_provider: dhcp_kea_api
+:server: {{ foreman_proxy_dhcp_kea_server }}
+:kea_url: {{ foreman_proxy_dhcp_kea_url }}


shouldn't this be kea_api_url?

also, we need kea_api_username and kea_api_password

evgeni · 2026-06-01T09:36:10Z

+:use_provider: dhcp_kea_api
+:server: {{ foreman_proxy_dhcp_kea_server }}
+:kea_url: {{ foreman_proxy_dhcp_kea_url }}
+:kea_subnet: {{ foreman_proxy_dhcp_kea_subnet }}


where does this come from? I don't see such an option in https://gitlab.surrey.ac.uk/sm0049/smart-proxy-dhcp-kea-api/

evgeni · 2026-06-01T09:45:36Z

Shall we package https://gitlab.surrey.ac.uk/sm0049/smart-proxy-dhcp-kea-api until we figure out whether we want to merge it into core or not?

archanaserver · 2026-06-02T08:04:21Z

Shall we package https://gitlab.surrey.ac.uk/sm0049/smart-proxy-dhcp-kea-api until we figure out whether we want to merge it into core or not?

Yeah, I was thinking we can package it for now, that will be independent of our decision about potentially merging it into the core later.

stejskalleos · 2026-06-02T12:47:02Z

 foreman_proxy_bmc_redfish_verify_ssl: true
+
+# DHCP settings
+foreman_proxy_dhcp_provider: dhcp_kea_api


Why not just:

Suggested change

foreman_proxy_dhcp_provider: dhcp_kea_api

foreman_proxy_dhcp_provider: dhcp_kea

stejskalleos · 2026-06-02T12:53:45Z

+:kea_api_password: {{ foreman_proxy_dhcp_kea_api_password }}
+{% endif %}
+{% if foreman_proxy_dhcp_kea_managed_subnets is defined and foreman_proxy_dhcp_kea_managed_subnets %}
+:managed_subnets:


There is a definition of subnets in DHCP as well: https://github.com/theforeman/smart-proxy/blob/develop/config/settings.d/dhcp.yml.example

stejskalleos · 2026-06-02T12:55:10Z

+foreman_proxy_dhcp_kea_api_url: "{{ undef(hint='You must specify the KEA API URL') }}"
+foreman_proxy_dhcp_kea_api_username: ""
+foreman_proxy_dhcp_kea_api_password: ""
+foreman_proxy_dhcp_kea_managed_subnets: []


I think this should be:

Suggested change

foreman_proxy_dhcp_kea_managed_subnets: []

foreman_proxy_dhcp_subnets: []

as in https://github.com/theforeman/smart-proxy/blob/develop/config/settings.d/dhcp.yml.example

evgeni · 2026-06-02T12:58:34Z

Shall we package https://gitlab.surrey.ac.uk/sm0049/smart-proxy-dhcp-kea-api until we figure out whether we want to merge it into core or not?

Yeah, I was thinking we can package it for now, that will be independent of our decision about potentially merging it into the core later.

Do you want to do it, or shall I?

archanaserver · 2026-06-04T05:56:42Z

Shall we package https://gitlab.surrey.ac.uk/sm0049/smart-proxy-dhcp-kea-api until we figure out whether we want to merge it into core or not?

Yeah, I was thinking we can package it for now, that will be independent of our decision about potentially merging it into the core later.

Do you want to do it, or shall I?

I'll do it

archanaserver · 2026-06-11T09:40:08Z

Update: Following the refinement session, we decided to integrate the KEA DHCP provider directly into smart-proxy core rather than packaging it as an external gem. I'm on it. So keeping this into draft till then.

Also looking at the current CI test failures, I believe they are coming from IOP tests failures and are unrelated to the DHCP feature changes in this PR.

archanaserver added 2 commits June 1, 2026 13:18

Add KEA DHCP provider feature for foreman-proxy

56d3600

Adds the dhcp-kea-external feature to enable Smart Proxy integration with external KEA DHCP servers.

Add feature test

83ef54c

pr-processor Bot added the Not yet reviewed label Jun 1, 2026

evgeni reviewed Jun 1, 2026

View reviewed changes

pr-processor Bot removed the Not yet reviewed label Jun 1, 2026

evgeni reviewed Jun 1, 2026

View reviewed changes

stejskalleos reviewed Jun 2, 2026

View reviewed changes

amolpati30 reviewed Jun 3, 2026

View reviewed changes

Comment thread src/features.yaml

Fix DHCP KEA settings

715b2e0

archanaserver force-pushed the dhcp-kea-external branch from 053aa03 to 715b2e0 Compare June 4, 2026 09:50

archanaserver marked this pull request as ready for review June 4, 2026 09:51

archanaserver marked this pull request as draft June 11, 2026 09:40

	foreman_proxy_dhcp_provider: dhcp_kea_api
	foreman_proxy_dhcp_provider: dhcp_kea

	foreman_proxy_dhcp_kea_managed_subnets: []
	foreman_proxy_dhcp_subnets: []

Conversation

archanaserver commented Jun 1, 2026 • edited by amolpati30 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why are you introducing these changes? (Problem description, related links)

What are the changes introduced in this pull request?

How to test this pull request

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

evgeni commented Jun 1, 2026

Uh oh!

archanaserver commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

evgeni commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

archanaserver commented Jun 4, 2026

Uh oh!

archanaserver commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

archanaserver commented Jun 1, 2026 •

edited by amolpati30

Loading

archanaserver commented Jun 2, 2026 •

edited

Loading

evgeni commented Jun 2, 2026 •

edited

Loading