Use role defaults for container images in IOP tests#542
Merged
Conversation
Replace hardcoded quay.io image references with an iop_image fixture that reads container_image and container_tag from each role's defaults, keeping tests in sync with deployment configuration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
evgeni
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
IOP tests hardcoded container image references (e.g.
quay.io/iop/host-inventory:latest), which meant they could drift out of sync with the actual images configured in role defaults. If the image or tag changed in deployment configuration, the tests would still use the old values.What are the changes introduced in this pull request?
iop_imagepytest fixture intests/iop/conftest.pythat readscontainer_imageandcontainer_tagfrom each role'sdefaults/main.yamlquay.io/iop/*image references acrosstest_advisor.py,test_ingress.py,test_integration.py, andtest_inventory.pywith calls to theiop_imagefixtureHow to test this pull request
Steps to reproduce:
python -m pytest tests/iop/ -vvpodman runcommands match the values from the corresponding role defaults undersrc/roles/Checklist