fix: mount /tmp as a tmpfs so that file names can be 255 in length#93
fix: mount /tmp as a tmpfs so that file names can be 255 in length#93dkuc wants to merge 1 commit into
Conversation
bb05225 to
832e3b6
Compare
| 'ContainerName' => 'iop-core-yuptoo', | ||
| 'Network' => 'iop-core-network', | ||
| 'Exec' => 'python -m main', | ||
| 'Tmpfs' => '/tmp:rw,size=2G,mode=1777', |
There was a problem hiding this comment.
I am a bit concerned that having three tmpfs mounts, all having an upper limit of 2Gi, could have a negative impact on the stability of the hosting system.
There was a problem hiding this comment.
It could also have positive impact - extracting and reading archives in memory instead of on disk should be faster and lessen disk I/O. Hard to say without measuring.
|
My immediate concern would be environments where it wouldn't be allowed to mount /tmp as tmpfs. |
|
The insights-core team did actually release an update that uses smaller file paths. However, the first upload you do uses the insights-core version that ships with insights-client. This first upload would fail - you would need to re-register and do a second upload to get this application side fix to work. |
Some customers have file systems that do not allow filenames up 255 characters. This change mounts the /tmp directory as tmpfs. This decouples the container from the host file system. This allows insights-core to create files with length of 255.
Note: tmpfs only claims memory as it needs it so this change will not result in a static 6GB of memory being allocated.
This is one potential fix for
https://issues.redhat.com/browse/SAT-42272#