feat: add from_pool constructor for PostgresDatabase#8
Open
Misaka15535 wants to merge 1 commit intothegenius:mainfrom
Open
feat: add from_pool constructor for PostgresDatabase#8Misaka15535 wants to merge 1 commit intothegenius:mainfrom
Misaka15535 wants to merge 1 commit intothegenius:mainfrom
Conversation
|
This will be useful to configure min/max connections too. Can we get this merged/released please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using PostgreSQL, I need to set the session time zone via after_connect, which requires control over how the PgPool is created. To support this, I added a from_pool constructor that allows injecting a pre-built connection pool.
Although this requirement currently applies only to PostgreSQL, I added the same from_pool method to other database implementations as well, for consistency across the API.