Skip to content

Centralize warning reporting#139

Merged
thejchap merged 2 commits into
thejchap:mainfrom
RaulBSanchez:raul/unify-scheduler-warnings
Jun 24, 2026
Merged

Centralize warning reporting#139
thejchap merged 2 commits into
thejchap:mainfrom
RaulBSanchez:raul/unify-scheduler-warnings

Conversation

@RaulBSanchez

Copy link
Copy Markdown
Contributor

Context

This was done as work for the bug #75

Changes

  1. I routed scheduler warnings through on_discovery_warning
    This was done to use the same flow as the discovery warnings
  2. I had to wrap the scheduler warning strings into a DiscoveryWarning object
    I got an error after changing reporter.on_scheduler_warning(w) to on_discovery_warning(w)
    It was trying to pass a string but need an object
  3. Added Scheduler to on_discovery_warning to handle this error
    DiscoveryWarningKind::Scheduler` not covered
  4. Used AI for this part - Added handling for DiscoveryWarningKind::Scheduler in the text reporter. This lets the scheduler warnings print correctly

Test plan

Cargo Test
They all passed

@RaulBSanchez RaulBSanchez requested a review from thejchap as a code owner June 14, 2026 20:34
@thejchap thejchap added the internal Refactor or cleanup with no user-visible behavior change label Jun 24, 2026
@thejchap thejchap changed the title changed the scheduler to use on_discovery_warning Centralize warning reporting Jun 24, 2026
@thejchap thejchap force-pushed the raul/unify-scheduler-warnings branch from 50643b0 to 7246844 Compare June 24, 2026 02:05
@thejchap

Copy link
Copy Markdown
Owner

Thanks @RaulBSanchez ! Made some minor tweaks

@thejchap thejchap merged commit 6cc777b into thejchap:main Jun 24, 2026
19 checks passed
@RaulBSanchez

Copy link
Copy Markdown
Contributor Author

Sweet - thanks @thejchap will try to make sense of them! Thanks again for letting me work on this project.

@RaulBSanchez RaulBSanchez deleted the raul/unify-scheduler-warnings branch June 24, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Refactor or cleanup with no user-visible behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants