Skip to content

feat/optional-fields #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pierrebaguet wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat/optional-fields #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7f0979
feat: improve category selection translation
Jan 23, 2026
ce7c94e
Merge pull request #1 from pierrebaguet/feat/optional-fields
pierrebaguet Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Config/module.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<language>en_US</language>
<language>fr_FR</language>
</languages>
<version>1.1.9</version>
<version>1.1.10</version>
<authors>
<author>
<name>Openstudio</name>
Expand Down
2 changes: 1 addition & 1 deletion Form/AbstractHeaderHighlightsImageForm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ protected function buildForm(): void
$categoriesArray = [];
$categories = (new CategoryQuery)->find();
$lang = $this->request->getSession()->get('thelia.current.lang');
$categoriesArray["Sélectionner une valeur"] = "";
$categoriesArray[Translator::getInstance()->trans('Choose a category', [], HeaderHighlights::DOMAIN_NAME)] = "";
foreach ($categories as $category) {
$categoryTitle = $category
->getTranslation($lang->getLocale())
Expand Down
1 change: 1 addition & 0 deletions I18n/fr_FR.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
'Button Link' => 'Lien de votre bouton',
'Catchphrase' => 'Accroche',
'Category' => 'Categorie',
'Choose a category' => 'Choisissez une categorie',
'Edit your Header' => 'Modifier vos encarts d\'accueil',
'Header Image does not exist' => 'L\'encart n\'existe pas',
'Header title' => 'Titre de votre encart',
Expand Down