fix: remove arch-specific SIMD files from unconditional sources list#17
Draft
peter-urban with Copilot wants to merge 1 commit into
Draft
fix: remove arch-specific SIMD files from unconditional sources list#17peter-urban with Copilot wants to merge 1 commit into
peter-urban with Copilot wants to merge 1 commit into
Conversation
…in meson.build The 'globbing' commit accidentally added simd_aarch64_neon.cpp, simd_x86_64_v1.cpp, simd_x86_64_v2.cpp, simd_x86_64_v3.cpp, and simd_x86_64_v4.cpp to the unconditional sources list. These files must only be compiled through their conditional paths with proper -march flags (v2/v3/v4 as separate static libraries, v1 conditionally for x86_64, neon for aarch64). Agent-Logs-Url: https://github.com/themachinethatgoesping/tools/sessions/abd1ef83-a7e7-48ac-b5bf-4946a2936b53 Co-authored-by: peter-urban <3885740+peter-urban@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
peter-urban
April 7, 2026 09:04
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sourceslist, so they compile without required-marchflagssourceslist