Add setup.py to fix install problem#156
Closed
marco-2023 wants to merge 1 commit intotheochem:masterfrom
Closed
Conversation
Gbasis has three folders in its main level and pypi gets lost during the the discovery of top-level packages during the installation. With this the package directory is set.
FarnazH
reviewed
Jan 11, 2024
Member
FarnazH
left a comment
FarnazH
left a comment
There was a problem hiding this comment.
@marco-2023, we are using pyproject.toml instead of setup.py; see #148.
I leave it to @Ali-Tehrani and @RichRick1 to resolve the issue you have encountered.
Contributor
|
Sorry for causing this to be an issue. Right now, if you try to install under editable mode it doesn't work: |
Contributor
Author
|
@Ali-Tehrani that is perfect, I will close this PR and work on the branch corresponding to PR #151. I noticed it because at the time I could not make a fresh installation.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gbasis has three folders in its main level and pypi gets lost during the the discovery of top-level packages during the installation. With this the package directory is set.
Checklist
Type of Changes
Related