Added safari extension template#26
Conversation
kirb
left a comment
kirb
left a comment
There was a problem hiding this comment.
Really excited to finally have some plugin templates, thanks for doing this 👍
Just had a few suggestions after looking over it again.
|
This looks like it fulfills Lillie's request (#25) |
Co-authored-by: Adam Demasi <adam@hbang.com.au>
Co-authored-by: Adam Demasi <adam@hbang.com.au>
Co-authored-by: Adam Demasi <adam@hbang.com.au>
| NIC->variable("PARENTPROJECTNAME") = ""; | ||
|
|
||
| while(NIC->variable("PARENTPROJECTNAME") eq "") { | ||
| NIC->variable("PARENTPROJECTNAME") = NIC->prompt("PROJ", "Name of parent project (required)"); |
There was a problem hiding this comment.
It may be worth specifying that by parent project name we mean an application name
|
@LillieH1000 would it be possible for you to confirm the functionality of this template? I am not familiar enough with safari extensions to be able to judge myself |
There was one change that @kirb was supposed to make back in 2022 to fix a bundle id issue of theos generating the wrong bundle id for it but besides that it was working in 2022. I'm in the theos discord and can let you know of the exact bundle id thing to make it easier if you want? |
|
That would be great. Thank you! |
|
Adjusted with the changes shared in the Theos discord this past summer. @LillieH1000 would you mind giving this a go to confirm that the issue(s) you identified are fixed? Thank you! |
Unfortunately I no longer own an iOS device/dev setup, so I have no proper way of testing this anymore, sorry :( |
4 participants
What does this implement/fix? Explain your changes.
adds a Safari extension template
Does this close any currently open issues?
no
Any relevant logs, error output, etc?
no
Any other comments?
no
Where has this been tested?
Operating System:
iOS 15.1.1
WSL - Ubuntu 20.04
Platform:
iOS/Linux
Target Platform: …
iOS/iPadOS
Toolchain Version:
clang version 10.0.0 (git@github.com:apple/llvm-project.git 3093af41dd65ad466dcd5603e9289244edfee4f5)
SDK Version:
iOS 14.4