Use GitHub actions for CI#152
Open
hansott wants to merge 6 commits intothephpleague:masterfrom
Open
Conversation
colinodell
requested changes
Dec 19, 2020
Member
colinodell
left a comment
colinodell
left a comment
There was a problem hiding this comment.
Adding my $0.02, others might have differing opinions :)
Comment on lines
+37
to
+44
| - name: "Cache dependencies" | ||
| uses: "actions/cache@v2" | ||
| with: | ||
| path: | | ||
| ~/.composer/cache | ||
| vendor | ||
| key: "php-${{ matrix.php-version }}-${{ matrix.dependencies }}" | ||
| restore-keys: "php-${{ matrix.php-version }}-${{ matrix.dependencies }}" |
Member
There was a problem hiding this comment.
Composer 2 without caching installs dependencies faster than either version of Composer with caching 😉 I recommend removing this and adding tools: composer:v2 to the "Install PHP" step (and doing this across all the workflows)
| dependencies: | ||
| - "locked" | ||
| php-version: | ||
| - "7.4" |
Member
There was a problem hiding this comment.
Can we include all currently-supported versions of PHP?
hansott
added a commit
to journy-io/php-sdk
that referenced
this pull request
Dec 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning:
https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
https://blog.travis-ci.com/oss-announcement
Inspired by
https://github.com/Roave/BetterReflection
I'm opening this PR to start a discussion, let me know if you want to proceed with this and what changes need to be made.
Some questions:
Some links to existing CI jobs of the PHP league: