CMake: fix find_package(Threads)#478
Merged
garyscavone merged 1 commit intothestk:masterfrom Feb 27, 2026
Merged
Conversation
`find_package(Threads)` does not take options, but CMAKE_THREAD_PREFER_PTHREAD/THREADS_PREFER_PTHREAD_FLAG are variables that need to be defined when calling find_package. This fixes configure errors when using conan_provider.cmake as package provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_package(Threads)does not take options, but CMAKE_THREAD_PREFER_PTHREAD/THREADS_PREFER_PTHREAD_FLAG are variables that need to be defined when calling find_package.This fixes configure errors when using conan_provider.cmake as package provider.