Added option to MidiApi to stop printing errors and warnings#228
Open
SarahVIAUD wants to merge 3 commits intothestk:masterfrom
Open
Added option to MidiApi to stop printing errors and warnings#228SarahVIAUD wants to merge 3 commits intothestk:masterfrom
SarahVIAUD wants to merge 3 commits intothestk:masterfrom
Conversation
…gs and errors to the console. This is especially useful when RtMidi object is initialised with no device connected yet, we don't necessary want a warning being printed.
|
Why didn't you make the printing itself a callback, which is by default initalised. This could use the current API. Exposing it in RtMidi.h would allow the user code to fall back to the default. The benefit is that you have to keep track of it in only one place. |
Author
|
"The printing itself a callback"? Not sure I understand what you mean... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a static function to MidiApi to be able to stop printing warnings and errors to the console.
This is especially useful when RtMidi object is initialised with no device connected yet, we don't necessary want a warning being printed.