Open
Conversation
Contributor
|
Does anyone have any feedback on this PR? I don't use CMake and the author isn't so confident that this actually fixes a problem. |
|
The patch looks fine to me. I can't judge if it fixes the issue of OP, but it is a correct change to make compile flag target private. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I used rtmidi with vcpkg and ran into problems with compiling it with
CMAKE_BUILD_TYPE debug. I'm not sure if this pull request fixes the problem, but if I understand it right then this at least doesn't propagate Werror to projects that add rtmidi as a dependency.Also
CMAKE_COMPILER_IS_GNUCXXis deprecated according to CMake docs, so I replaced it with what was written there.