Mongoid 6 & 7 and rails 5.1, 5.2 & 6.0 upgrade by ritxi · Pull Request #77 · thetron/mongoid_token

ritxi · 2017-07-31T08:14:20Z

Mongoid 6 & 7 upgrade
Remove alias_method_chain to make it compatible with rails 5.1 or above

spec/mongoid/token_spec.rb

spec/mongoid/token/collisions_spec.rb

lib/mongoid/token.rb

spec/mongoid/token_spec.rb

spec/mongoid/token/collisions_spec.rb

lib/mongoid/token.rb

houndci-bot · 2017-07-31T08:27:21Z

spec/spec_helper.rb

@@ -1,5 +1,6 @@
+require "simplecov"


Missing magic comment # frozen_string_literal: true.

houndci-bot · 2017-07-31T08:47:07Z

spec/mongoid/token_spec.rb

+      it { expect(document.sharing_id).to match(/[a-z]{4}/) }
+    end
+
+    context "should raise exception for duplicated token" do


Block has too many lines. [26/25]

…ers array instead

# Conflicts: # mongoid_token.gemspec

houndci-bot · 2019-12-03T08:24:23Z

spec/spec_helper.rb

@@ -1,5 +1,6 @@
+require "simplecov"


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

spec/mongoid/token_spec.rb

spec/mongoid/token/finders_spec.rb

spec/mongoid/token/collisions_spec.rb

lib/mongoid_token.rb

spec/mongoid/token_spec.rb

spec/mongoid/token/generator_spec.rb

spec/mongoid/token_spec.rb

spec/mongoid/token/generator_spec.rb

spec/mongoid/token/collisions_spec.rb

lib/mongoid/token/options.rb

houndci-bot · 2019-12-03T09:50:07Z

lib/mongoid/token/options.rb

-    end
-    options
-  end
+      private


Layout/EmptyLinesAroundAccessModifier: Keep a blank line before and after private.

lib/mongoid/token/options.rb

spec/mongoid/token_spec.rb

spec/mongoid/token/options_spec.rb

spec/mongoid/token/finders_spec.rb

lib/mongoid/token/options.rb

houndci-bot · 2019-12-03T10:19:36Z

lib/mongoid/token/options.rb

-  def initialize(options = {})
-    @options = merge_defaults validate_options(options)
-  end
+module Mongoid


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-12-03T10:19:37Z

lib/mongoid/token/error.rb

@@ -0,0 +1,5 @@
+module Mongoid


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

Gemfile

spec/mongoid/token_spec.rb

spec/mongoid/token/collisions_spec.rb

houndci-bot · 2019-12-03T12:18:30Z

spec/mongoid/token/collisions_spec.rb

  end

-  describe "#is_duplicate_token_error?" do
+  describe "#duplicate_token_error?" do


Metrics/BlockLength: Block has too many lines. [32/25]

lib/mongoid/token/collisions.rb

Gemfile

spec/mongoid/token_spec.rb

lib/mongoid/token/options.rb

lib/mongoid/token/generator.rb

houndci-bot · 2019-12-03T14:22:11Z

Gemfile

-  gem 'database_cleaner'
-  gem 'mongoid-rspec', '1.5.1'
+  gem "rspec"
+  gem "database_cleaner"


Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem database_cleaner should appear before rspec.

Add rails 5.1 Add rails 5.1 to travisci

houndci-bot · 2019-12-03T15:21:03Z

spec/mongoid/token_spec.rb

+      it { expect(document.sharing_id).to match(/[a-z]{4}/) }
+    end
+
+    context "should raise exception for duplicated token" do


Metrics/BlockLength: Block has too many lines. [30/25]

jclusso · 2020-10-28T21:05:24Z

@ritxi I'm using your master branch and I'm getting a zeitwerk error. NameError: uninitialized constant MongoidToken

$ bin/rails zeitwerk:check
Hold on, I am eager loading the application.
rails aborted!
NameError: uninitialized constant MongoidToken
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/zeitwerk-2.4.0/lib/zeitwerk/loader.rb:392:in `const_get'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/zeitwerk-2.4.0/lib/zeitwerk/loader.rb:392:in `block (2 levels) in eager_load'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/zeitwerk-2.4.0/lib/zeitwerk/loader.rb:742:in `block in ls'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/zeitwerk-2.4.0/lib/zeitwerk/loader.rb:734:in `foreach'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/zeitwerk-2.4.0/lib/zeitwerk/loader.rb:734:in `ls'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/zeitwerk-2.4.0/lib/zeitwerk/loader.rb:387:in `block in eager_load'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/zeitwerk-2.4.0/lib/zeitwerk/loader.rb:376:in `synchronize'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/zeitwerk-2.4.0/lib/zeitwerk/loader.rb:376:in `eager_load'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/zeitwerk-2.4.0/lib/zeitwerk/loader.rb:494:in `each'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/zeitwerk-2.4.0/lib/zeitwerk/loader.rb:494:in `eager_load_all'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/railties-6.0.3.4/lib/rails/tasks/zeitwerk.rake:11:in `block in <main>'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/railties-6.0.3.4/lib/rails/tasks/zeitwerk.rake:47:in `block (2 levels) in <main>'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/railties-6.0.3.4/lib/rails/commands/rake/rake_command.rb:23:in `block in perform'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/railties-6.0.3.4/lib/rails/commands/rake/rake_command.rb:20:in `perform'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/railties-6.0.3.4/lib/rails/command.rb:48:in `invoke'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/railties-6.0.3.4/lib/rails/commands.rb:18:in `<main>'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/bootsnap-1.4.8/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:23:in `require'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/bootsnap-1.4.8/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:23:in `block in require_with_bootsnap_lfi'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/bootsnap-1.4.8/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in `register'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/bootsnap-1.4.8/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `require_with_bootsnap_lfi'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/bootsnap-1.4.8/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:31:in `require'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/activesupport-6.0.3.4/lib/active_support/dependencies.rb:324:in `block in require'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/activesupport-6.0.3.4/lib/active_support/dependencies.rb:291:in `load_dependency'
/Users/jarrett/.rvm/gems/ruby-2.7.2@project/gems/activesupport-6.0.3.4/lib/active_support/dependencies.rb:324:in `require'
bin/rails:4:in `<main>'
Tasks: TOP => zeitwerk:check
(See full trace by running task with --trace)```

ritxi · 2020-10-28T22:35:16Z

What version of zeitwerk you use, may be newer versions have problems. Do you have more details to try to reproduce the error? El dc., 28 d’oct. 2020, 22:05, Jarrett Lusso <notifications@github.com> va escriure:

…

@ritxi <https://github.com/ritxi> I'm using your master branch and I'm getting a zeitwerk error. NameError: uninitialized constant MongoidToken — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#77 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABDQ3GLMI67NJPGZK7EKBTSNCBSJANCNFSM4DVAE73Q> .

jclusso · 2020-10-28T22:37:04Z

@ritxi I'm using zeitwerk (2.4.0) and rails (6.0.3.4). I can reproduce the error by just running the bin/rails zeitwerk:check.

jclusso · 2020-10-29T03:03:26Z

Not sure this is the best way to fix it, but this got the gem to load properly. I doubt this is the cleanest solution. jclusso@f1048a4

houndci-bot reviewed Jul 31, 2017

View reviewed changes

spec/spec_helper.rb

@@ -1,5 +1,6 @@

require "simplecov"

Copy link

Collaborator

houndci-bot Jul 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing magic comment # frozen_string_literal: true.

Refactor #alias_method_chain implementation with ruby's native #prepend

8b28b6b

ritxi force-pushed the master branch from 139e964 to 73cba77 Compare July 31, 2017 08:46

houndci-bot reviewed Jul 31, 2017

View reviewed changes

ritxi changed the title ~~Mongoid 6 and rails 5.2 upgrade~~ Mongoid 6 and rails 5.1 upgrade Jul 31, 2017

Ricard Forniol added 5 commits July 31, 2017 10:51

remove resolver parameter from resolve_token_collisions lookup resolv…

e9da5aa

…ers array instead

Upgrade mongoid version

fbb61df

# Conflicts: # mongoid_token.gemspec

Ensure non mongoid_token exceptions are cought and tokens regenerated

1796f59

Remove older ruby versions

30537c3

Make code climate reporting work

b256286

ritxi force-pushed the master branch from 73cba77 to b256286 Compare July 31, 2017 08:52

Make exception assertion compatible with mongo 2.4

4520306

ritxi mentioned this pull request Aug 7, 2017

Mongoid 6 support #75

Open

Ricard Forniol added 2 commits December 2, 2019 17:43

Gem autoload using zeitwerk

6f1b7f9

Update mongo version

46aa33a

houndci-bot reviewed Dec 3, 2019

View reviewed changes

ritxi force-pushed the master branch from 45d5dd2 to bdba42e Compare December 3, 2019 09:34

houndci-bot reviewed Dec 3, 2019

View reviewed changes

ritxi force-pushed the master branch from bdba42e to 975104d Compare December 3, 2019 09:49

houndci-bot reviewed Dec 3, 2019

View reviewed changes

Use new :expect syntax

606c5a8

ritxi force-pushed the master branch from 975104d to dc6175c Compare December 3, 2019 10:19

houndci-bot reviewed Dec 3, 2019

View reviewed changes

spec/mongoid/token_spec.rb Outdated Show resolved Hide resolved

lib/mongoid/token/options.rb Outdated Show resolved Hide resolved

lib/mongoid/token/generator.rb Outdated Show resolved Hide resolved

ritxi force-pushed the master branch from 5b547e5 to ac4a3b2 Compare December 3, 2019 14:22

houndci-bot reviewed Dec 3, 2019

View reviewed changes

ritxi force-pushed the master branch from ac4a3b2 to 34531b4 Compare December 3, 2019 14:27

ritxi force-pushed the master branch from 34531b4 to 06365d7 Compare December 3, 2019 14:40

ritxi changed the title ~~Mongoid 6 and rails 5.1 upgrade~~ Mongoid 6 & 7 and rails 5.2 & 6.0 upgrade Dec 3, 2019

ritxi force-pushed the master branch from 06365d7 to 01e53de Compare December 3, 2019 14:49

ritxi changed the title ~~Mongoid 6 & 7 and rails 5.2 & 6.0 upgrade~~ Mongoid 6 & 7 and rails 5.1, 5.2 & 6.0 upgrade Dec 3, 2019

Ricard Forniol added 3 commits December 3, 2019 15:53

Add appraisals

c27cbf5

Add rails 5.1 Add rails 5.1 to travisci

Use more ruby naming convention duplicate_token_error?

f86f7c4

Ensure collisions to work on mongodb 2.6. 3.0 and 4.0

d53a1f8

ritxi force-pushed the master branch 2 times, most recently from 2cdf762 to 4377440 Compare December 3, 2019 15:20

houndci-bot reviewed Dec 3, 2019

View reviewed changes

ritxi force-pushed the master branch from 4377440 to c7f77b6 Compare December 3, 2019 15:28

Fix rubocop errors

9e04f9c

ritxi force-pushed the master branch from c7f77b6 to 9e04f9c Compare December 3, 2019 15:47

Update README

8b0b106

Comments

Conversation

ritxi commented Jul 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ritxi commented Jul 31, 2017 •

edited

Loading

jclusso commented Oct 28, 2020 •

edited

Loading