Skip to content

ci(build): added build test for PRs, removed PRs from push WF#102

Open
ulnanlu wants to merge 13 commits intothezak48:developfrom
ulnanlu:ci-update
Open

ci(build): added build test for PRs, removed PRs from push WF#102
ulnanlu wants to merge 13 commits intothezak48:developfrom
ulnanlu:ci-update

Conversation

@ulnanlu
Copy link
Copy Markdown
Contributor

@ulnanlu ulnanlu commented Oct 13, 2025

the title. no idea if it works...

@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@thezak48 thezak48 requested a review from Copilot October 13, 2025 21:33
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR separates Docker build workflows by creating a dedicated test workflow for pull requests while simplifying the main Docker build workflow for pushes and tags. This allows for faster PR validation without publishing images.

  • Created a new test-only workflow for PR validation with smoke testing
  • Removed PR triggers from the main Docker build workflow
  • Simplified path ignore patterns using wildcard notation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/docker-build.yml Removed PR triggers and simplified path ignore patterns to only handle pushes/tags
.github/workflows/docker-build-test.yml New workflow for PR testing with Docker build validation and smoke tests

Comment thread .github/workflows/docker-build-test.yml Outdated
Comment thread .github/workflows/docker-build-test.yml Outdated
Comment thread .github/workflows/docker-build-test.yml Outdated
@ulnanlu ulnanlu requested a review from Copilot October 16, 2025 22:50
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/docker-build-test.yml Outdated
Comment thread .github/workflows/docker-build-test.yml Outdated
@ulnanlu ulnanlu requested a review from Copilot October 16, 2025 23:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread .github/workflows/docker-build-test.yml
Comment thread .github/workflows/docker-build.yml
Comment thread .github/workflows/docker-build-test.yml
@ulnanlu
Copy link
Copy Markdown
Contributor Author

ulnanlu commented Oct 16, 2025

i think i'm done with everything.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants