Revert DB connection reuse to address warning from CI test#130
Closed
mbhutton wants to merge 1 commit intothingsapi:mainfrom
mbhutton:fix/dont-reuse-db-connection
Closed
Revert DB connection reuse to address warning from CI test#130mbhutton wants to merge 1 commit intothingsapi:mainfrom mbhutton:fix/dont-reuse-db-connection
mbhutton wants to merge 1 commit intothingsapi:mainfrom
mbhutton:fix/dont-reuse-db-connection
Conversation
This reverts commit 0ed2f9d. This addresses a CI test warning: 'ResourceWarning: unclosed database'.
|
Contributor
Author
|
Closing this PR, in favour of a better strategy which allows connection reuse as well as proper cleanup in a way that satisfies the test suite without warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0ed2f9d, which added DB connection reuse.
That reuse produced a CI test warning ('ResourceWarning: unclosed database'), hence this PR to back it out.