Fixed arbitrary file write in TBEL script sandbox#50
Open
zzzeebra wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
java.util.FormatterinSandboxedClassLoadervia a newforbiddenClassesexact-match denylistjava.util.FormatterProblem
The
allowedPackagesentry"java.util"usesstartsWithprefix matching, which permits every top-leveljava.utilclass.java.util.Formatterhas aFormatter(String fileName)constructor that opens the named file for writing, so a Tenant Admin can write arbitrary content to an arbitrary path from a TBEL script:Fix
Add
java.util.Formatterto aforbiddenClassesset that is checked first inclassNameAllowed, so the denylist wins over thejava.utilpackage allow and the class can no longer be loaded. This follows the existing forbidden-list pattern; the escape now fails at class resolution withcould not resolve class: java.util.Formatter, identical to the blocked subpackages.Test plan
Automated test in
TbExpressionsTest:testForbiddenFormatterFileWrite— verifiesnew java.util.Formatter(...)is blocked and no file is created.All 98 tests in
TbExpressionsTestpass (legitimatejava.utilcollections are unaffected).