Skip to content

Conversation

@joente
Copy link
Member

@joente joente commented Dec 7, 2024

Description

Add two new functions to the @thingsdb scope. Whitelists are active cross scope, so when you whitelist a procedure or room name, it will allow rooms and procedures with this name in all scopes where the user has access too. Besides simple names, regular expressions are also supported which will allow certain name conventions to allow multiple rooms or procedures at once. for example the procedures rule /^api_.*/ would allow all procedures starting with api_.

See discussion #391

(this pr also implements issue #394)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Update existing tests
  • Added new whitelist test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@joente joente self-assigned this Dec 7, 2024
@joente joente merged commit ee9089d into main Dec 7, 2024
1 check passed
@joente joente deleted the whitelist branch December 21, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants