Skip to content

[express-apollo-prisma] Final cleanup from demo feedback #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iansamz wants to merge 19 commits into
base: main
Choose a base branch
from
Open

[express-apollo-prisma] Final cleanup from demo feedback #1207

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
85932bb
fix: dustin's remarks
iansamz Mar 27, 2023
314dab5
fix: pagination conventions
iansamz Mar 29, 2023
4d0e7ff
items -> edges
iansamz Mar 30, 2023
073ef40
Technology Collection
iansamz Mar 30, 2023
42564e7
chore: update collectionpage -> collection
iansamz Mar 30, 2023
b611c3b
chore: implement cursor based pagination
iansamz Mar 30, 2023
e88439b
chore: add startCursor
iansamz Mar 30, 2023
4e91366
fix: remove console
iansamz Mar 30, 2023
b9bd943
refactor: use global configuration file
mbicknese Mar 30, 2023
5cf6aed
chore: add node
iansamz Mar 30, 2023
8afc0e9
fix: PaginationInformation -> PageInformation
iansamz Mar 30, 2023
a4e5489
chore: tests to 100
iansamz Mar 31, 2023
aec6ed4
fix: tests to 100%
iansamz Mar 31, 2023
c2856ed
chore: ignore config.ts
iansamz Mar 31, 2023
56b21fd
refactor: use global configuration file
mbicknese Mar 30, 2023
127f99e
chore: ignore worker.ts from jest tests
iansamz Mar 31, 2023
29885e6
chore: update readme with mongodb and blog post
iansamz Apr 4, 2023
3de58bf
chore: added new line editorconfig
iansamz Apr 4, 2023
414255a
chore: TechnologyNode -> TechnologyEdge
iansamz Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions starters/express-apollo-prisma/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,6 @@ indent_size = 2
[*.md]
max_line_length = off
trim_trailing_whitespace = false

[{package.json, eslintrc.json}]
indent_style = space
5 changes: 2 additions & 3 deletions starters/express-apollo-prisma/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,9 @@
"scripts": {
"codegen": "graphql-codegen && npm run format:codegen",
"prepare": "npm run prisma:generate && npm run codegen",
"test": "npm run prepare && jest",
"test": "jest",
"start": "npm run prepare && prisma migrate dev && nodemon",
"dev:test": "jest",
"dev:start": "nodemon",
"dev": "nodemon",
"build": "npm run prepare && tsc --project tsconfig.build.json",
"lint": "eslint \"src/**/*.ts\"",
"lint:fix": "npm run lint --fix",
Expand Down
6 changes: 3 additions & 3 deletions starters/express-apollo-prisma/src/graphql/data-sources/technology-data-source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ type TechnologyEntityId = TechnologyEntity['id'];

export type TechnologyEntityCollectionPage = {
totalCount: number;
items: TechnologyEntity[];
edges: TechnologyEntity[];
};

export class TechnologyDataSource {
Expand All @@ -31,7 +31,7 @@ export class TechnologyDataSource {
}

async getTechnologies(limit: number, offset: number): Promise<TechnologyEntityCollectionPage> {
const [totalCount, items] = await this.prismaClient.$transaction([
const [totalCount, edges] = await this.prismaClient.$transaction([
this.prismaClient.technologyEntity.count(),
this.prismaClient.technologyEntity.findMany({
take: limit,
Expand All @@ -40,7 +40,7 @@ export class TechnologyDataSource {
]);
return {
totalCount,
items,
edges,
};
}

Expand Down
6 changes: 3 additions & 3 deletions starters/express-apollo-prisma/src/graphql/schema/technology/technology.typedefs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ export const technologyTypeDefs = gql`
"""
A page of technology items
"""
type TechnologyCollectionPage {
type TechnologyCollection {
"Identifies the total count of technology records in data source"
totalCount: Int!
"A list of records of the requested page"
items: [Technology]!
edges: [Technology]!
}

"""
Expand All @@ -32,7 +32,7 @@ export const technologyTypeDefs = gql`
"Returns a single Technology by ID"
technology(id: ID!): Technology
"Returns a list of Technologies"
technologies(limit: Int = 5, offset: Int = 0): TechnologyCollectionPage!
technologies(limit: Int = 5, offset: Int = 0): TechnologyCollection!
}

input CreateTechnology {
Expand Down