Sequelize latest #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- coding style - support both definition styles
- removing incomplete dataType check - styling code more like the rest of the project
The auto-generated migrations don't mention done which is confusing if you're new to sequelize.
…en_async_update Update the generated migration skeleton for async
Better error message for bad data types in define
…e to string concatenation. This has a large performance impact when doing many queries and having big result sets (attributesToSQL function)
…e to string concatenation. This has a large performance impact when doing many queries and having big result sets (attributesToSQL function)
…lum/sequelize into mysql-performance-improvements Conflicts: lib/dialects/mysql/query-generator.js
…ents Performance improvements for MySQL query generator
Min/Max decimal support closes sequelize#579
…/sequelize into mekanics-postgres-clause-order-fix
In the MySQL dialect, values used to generate insert, bulk insert, and update queries are now checked for boolean-ness and will be turned into an int. There was already duplicated logic applied to outgoing values to check if the value was a Date or not. I factored out value processing to a single function and added a check for typeof boolean. The new function also escapes the return value since that was also being done everywhere. Fixes sequelize#607
Still defaults to 'development' if NODE_ENV isn't set so backwards compatibility is ensured.
Also replaced one thrown error with a console.log. The rest of the errors were not thrown, and since this file is run from the shell, it will be an edge case that it will ever be caught. It looks messy when it happens. So it now returns an exit code of 1 to indicate things went sideways.
Because I always forget to add one to 'down' and then my migrations don't undo. Also upgraded a ==.
And quit with a code after outputting it.
Make it possible to specify query options for find and findAll (specifically raw: true)
…uelize into terraflubb-make_binary_verbose
…tinyints Properly process booleans in MySQL dialect to fix sequelize#607
thomascool
added a commit
that referenced
this pull request
Mar 21, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.