Skip to content

Update super_sstable_reader.go #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sebheitzmann wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Update super_sstable_reader.go #66

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee2ae66
Update super_sstable_reader.go
sebheitzmann Apr 8, 2025
bcff906
add tombstone in index
sebheitzmann Apr 8, 2025
2b2886b
indexval with tombstone
sebheitzmann Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions sstables/super_sstable_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,9 @@ func (s SuperSSTableReader) Contains(key []byte) (bool, error) {
if err != nil {
return false, err
}
if !keyExist {
continue
if keyExist {
return true, nil
Copy link
Owner

@thomasjungblut thomasjungblut Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind to add a unit test for this too? I wonder why this just passes :D

Copy link
Contributor Author

@sebheitzmann sebheitzmann Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check if the test cover this

Copy link
Owner

@thomasjungblut thomasjungblut Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this as part of 44b5b67

thanks for fixing this as well, I'll see whether we need some more test coverage around this right now

}
// we have to check if the value is not tombstoned
// maybe had to be implemented in an IsTombstoned in sstableReader
res, err := s.readers[i].Get(key)
return res != nil, err
}

return false, nil
Expand Down
Loading