Issue #187 : Add peek_back to tpie::file_stream#261
Open
ssoelvsten wants to merge 5 commits intothomasmoelhave:masterfrom
Open
Issue #187 : Add peek_back to tpie::file_stream#261ssoelvsten wants to merge 5 commits intothomasmoelhave:masterfrom
peek_back to tpie::file_stream#261ssoelvsten wants to merge 5 commits intothomasmoelhave:masterfrom
Conversation
ssoelvsten
changed the title
peek_back to tpie::file_stream
Contributor
Author
|
Also, now looking at said code: what is the meaning behind the use of the word unlikely in |
ssoelvsten
force-pushed
the
file_stream/peek_back
branch
from
0bf4c0e to
5b3fffa
Compare
ssoelvsten
force-pushed
the
file_stream/peek_back
branch
from
5b3fffa to
69d1e88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #187 by adding a
peek_backfunction totpie::file_stream. Furthermore also improves the order of the functions, their documentation (quite a few had missing documentation), whitespace, and adds aread_backfunction given an iterator.This has been extensively tested on my research project (ssoelvsten/adiar#374).