Skip to content

Conversation

@thomaspoignant
Copy link
Owner

Description

fix some sonar warnings

Checklist

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
…heck.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@netlify
Copy link

netlify bot commented Dec 2, 2025

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 4668bef
🔍 Latest deploy log https://app.netlify.com/projects/go-feature-flag-doc-preview/deploys/692e962d5edc36000896ace2

@netlify
Copy link

netlify bot commented Dec 2, 2025

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 32b7b55
🔍 Latest deploy log https://app.netlify.com/projects/go-feature-flag-doc-preview/deploys/693bd6d0d4be800008dcff6a

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 86.95652% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.31%. Comparing base (3a7ca53) to head (32b7b55).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cli/evaluate/evaluate.go 66.66% 1 Missing and 1 partial ⚠️
cmd/cli/generate/manifest/manifest_cmd.go 33.33% 1 Missing and 1 partial ⚠️
cmd/cli/helper/print_output.go 33.33% 1 Missing and 1 partial ⚠️
cmd/relayproxy/api/server.go 88.88% 1 Missing ⚠️
cmd/relayproxy/config/config_validator.go 50.00% 1 Missing ⚠️
cmd/relayproxy/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4391      +/-   ##
==========================================
- Coverage   85.33%   85.31%   -0.03%     
==========================================
  Files         145      145              
  Lines        6056     6059       +3     
==========================================
+ Hits         5168     5169       +1     
+ Misses        663      661       -2     
- Partials      225      229       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant marked this pull request as ready for review December 10, 2025 08:39
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@sonarqubecloud
Copy link

@thomaspoignant thomaspoignant merged commit fad894e into main Dec 12, 2025
22 checks passed
@thomaspoignant thomaspoignant deleted the fix-sonar branch December 12, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants