feat(units): improved appearance of unit cards #323
Conversation
Duy-Nguyen1104
left a comment
Duy-Nguyen1104
left a comment
There was a problem hiding this comment.
Hi. I have fetch your PR and tested out the updated card components and it works good enough for a front-end mock-up. My advice is that instead of the attribute prerequisite and corequisite, you should replace that with level and and credit points since not all units have pre/corequisite. Additionally, you could take a look at my PR (#309) which I have added CSS so that the cards look similar to the courseflow mockup (https://ontrackdocumentation.netlify.app/courseflow/diagrams/) and apply that if you want.
|
Hi Agam! |
|
Hi Agam! |
|
Hey Agam! I have reviewed your newly updated changes. Everything works well with the new updates. |
| params.set('Unit Tutor first name', unitTutorFirstName); | ||
| params.set('Unit Tutor last name', unitTutorLastName); |
There was a problem hiding this comment.
These shouldn't be in courseflow - there is no need to include this, unless they are used.
| startDate: Date; | ||
| endDate: Date; | ||
| selectedTeachingPeriod: number = null; | ||
| corequisite: string = "null"; |
There was a problem hiding this comment.
This should not be a "null" string, but just null.
5 participants
Description
For this task, I first looked at different unit websites and the information provided by them, I first looked at the most commonly checked details, such as the credit points that the units have, the prerequisite units the unit must have and what units are required alongside the unit, so I first made changes to the unit database and added the creditpoint, prerequisite and corequisite units in the database, so previously where the courseflow would only show the unit name and ID, now it shows the creditpoints, prerequisite and the corequisite units in the code.
In the create unit form, now a new input form of credit points has also been added, which asks for the credit point from the admin when creating a new unit, in the database, the default values of the new unit for corequisite and the prerequisite are nil.
Fixes # (issue)
Type of change
How Has This Been Tested?
To test this unit, I logged in as the admin and created a new unit and checked if the code is made with a credit point or not, I then went to courseflow and then enterred the unit to check if the unit is being presented as desired.
When you place the unit in the study period and click on the "..." on the bottom of the unit cards to see the unit overlay with all the information for the unit
Make sure that you are on new/course-flow branch on the doubtfire-web and 9.x branch on doubtfire-api and doubtfire-deploy
Testing Checklist:
Checklist: