Skip to content

Conversation

@vaghelaparth05
Copy link

Any italic text should be deleted from the final Pull Request text, including this line

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [✓] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Testing Checklist:

  • [✓] Tested in latest Chrome
image
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • [✓] My code follows the style guidelines of this project
  • [✓] I have performed a self-review of my own code
  • [✓] I have commented my code in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [✓] My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

@AB-Deakin
Copy link

Quick update on the PR I have started the code review and currently the branch is being merged into development causing the 223 commits your branch is ahead trying to merge into the development branch. Can you update the PR to merge into the 9.0x branch?

@AB-Deakin
Copy link

PR

@vaghelaparth05 vaghelaparth05 changed the base branch from development to 9.x September 16, 2025 10:37
@vaghelaparth05
Copy link
Author

I've updated the base branch to 9.x. Now it doesn't have the commits from 3 years ago. Its all fixed now. Thank You clarifying this.

@AB-Deakin
Copy link

I've loaded and tested the change so far, looks like the old component is not yet unhooked from doubtfire-angularjs.module.ts and directives.coffee (this is the last component in directives.coffee so it may be possible to delete it and remove its reference from angular as well) as attached in the screenshots, you'll need to remove these lines and test some more to see if the app will build correctly.

It will also need the description and how has this been tested sections of the Pull Request filled out as well as these are still filled with the template text. Testing screenshots will need to be a bit more detailed showing the steps to access the section and what was done to test that the components still work.

DEL
DEL2
DEL3

Copy link

@Triet-coder Triet-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-21 150054 Screenshot 2025-09-21 150141 Screenshot 2025-09-21 150147 Screenshot 2025-09-21 150153 Looks good — unit-dates-selector migration works smoothly. Rollover page loads, teaching-period dropdown + dates bind correctly, and Create stays disabled until valid (tested in latest Safari). Tiny nits: null-check @input() unit, add a test for “no teaching periods”, and maybe debounce/disable while loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants