Add platform properties functionality to mettle workers#352
Open
scyyx5 wants to merge 1 commit into
Open
Conversation
Hamishpk
reviewed
Jun 15, 2026
Hamishpk
left a comment
Hamishpk
left a comment
Contributor
There was a problem hiding this comment.
Two small nits but otherwise looks good to me
| logr.WithFields(logrus.Fields{ | ||
| "hash": w.actionDigest.Hash, | ||
| "platformProperties": formatPlatformProperties(w.platformProps), | ||
| }).Info("Action specifies platform properties; would use them to select sandbox filesystem") |
Contributor
There was a problem hiding this comment.
nit: platform properties may be used for many things so I would shorten this just to list the platform properties and not mention the sandbox
|
|
||
| assert.Equal(t, original, copied) | ||
|
|
||
| original["filesystem"] = "tmpfs" |
Contributor
There was a problem hiding this comment.
Do we need this line here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.