Skip to content

Revert mettle temp debug logs#354

Merged
olha-ctrl merged 4 commits into
thought-machine:masterfrom
olha-ctrl:INFRA-130229_revert_debug_logs
Jun 16, 2026
Merged

Revert mettle temp debug logs#354
olha-ctrl merged 4 commits into
thought-machine:masterfrom
olha-ctrl:INFRA-130229_revert_debug_logs

Conversation

@olha-ctrl

Copy link
Copy Markdown
Contributor

The original issue causing timeouts has been fixed. This change removes the temporary logging that was added to help investigate the hanging processes.

@olha-ctrl olha-ctrl requested review from Hamishpk and toastwaffle June 8, 2026 09:51

@toastwaffle toastwaffle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually want to remove this? how much of a cost are we paying for this remaining here?

Comment thread mettle/worker/worker.go Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz fix lint

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the linter. I had a chat with Hamish and we decided to remove it as it's ~300lines on code; if we need it one day, we can revert this change

Comment thread mettle/worker/worker.go Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this whole go routine as without the logging it will no longer do anything

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@olha-ctrl olha-ctrl merged commit dab2afb into thought-machine:master Jun 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants