Skip to content

Several code improvements #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kodejuice wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Several code improvements #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50e7b28
Several code improvements
kodejuice Sep 11, 2021
1d7b8f2
Update App.tsx
kodejuice Sep 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,18 @@ const CodeInput = () => {
const [code, setCode] = useState('');
const [containerIsFocused, setContainerIsFocused] = useState(false);

const codeDigitsArray = new Array(CODE_LENGTH);
const codeDigitsArray = [...Array(CODE_LENGTH)];
Copy link
Author

@kodejuice kodejuice Sep 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use spread operator to create array of CODE_LENGTH length, the original code could not be mapped

Copy link

@jefelewis jefelewis Oct 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed my issue as well. Otherwise, the fields do not show.


const ref = useRef<TextInput>(null);

const setCodeInput = (input: string) => {
Copy link
Author

@kodejuice kodejuice Sep 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore non-numeric input

if (input.length === 0) setCode(input);
const last = input[input.length - 1];
if (last?.trim() === '') return; // ignore space, (+' ') == 0
// make sure the input is numeric before updating
if (+last >= 0 && +last <= 9) setCode(input);
};

const handleOnPress = () => {
setContainerIsFocused(true);
ref?.current?.focus();
Expand All @@ -37,10 +45,10 @@ const CodeInput = () => {

const isFocused = isCurrentDigit || (isLastDigit && isCodeFull);

const containerStyle =
containerIsFocused && isFocused
? {...style.inputContainer, ...style.inputContainerFocused}
: style.inputContainer;
const containerStyle = [
Copy link
Author

@kodejuice kodejuice Sep 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the style prop can accept an array of styles

style.code_input_inputContainer,
isFocused && containerIsFocused && style.code_input_inputContainerFocused,
];

return (
<View key={idx} style={containerStyle}>
Expand All @@ -57,8 +65,9 @@ const CodeInput = () => {
<TextInput
ref={ref}
value={code}
onChangeText={setCode}
onChangeText={setCodeInput}
onSubmitEditing={handleOnBlur}
onBlur={handleOnBlur}
keyboardType="number-pad"
returnKeyType="done"
textContentType="oneTimeCode"
Expand Down