tiffs with npages not dividing by pageCount will give a warning instead an error#313
Merged
freeman-lab merged 2 commits intothunder-project:masterfrom May 26, 2016
Merged
Conversation
… of pages in a tif file
Member
|
Why don't we forget the warning stuff, because doing warnings on the workers well is hard, and instead add a keyword argument like |
Member
|
Warnings should be done like this: Line 4 in 0f2e29f |
- added a test
Contributor
Author
|
@freeman-lab Thanks for the comments! |
Member
|
Excellent, looks good to me @boazmohar , merging in! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative implementation to #279
Thinking of adding a flag to
fromtif()that would default to the current behavior of rising an error.Also I am sending the warning using the
warningmodule, I saw another way using the spark logger:@sofroniewn @freeman-lab What do you guys think?