Skip to content

fix: unified inbox swipe delete#11000

Open
namelessweakl1ng wants to merge 2 commits into
thunderbird:mainfrom
namelessweakl1ng:fix/unified-inbox-swipe-delete
Open

fix: unified inbox swipe delete#11000
namelessweakl1ng wants to merge 2 commits into
thunderbird:mainfrom
namelessweakl1ng:fix/unified-inbox-swipe-delete

Conversation

@namelessweakl1ng

Copy link
Copy Markdown

Summary

Fixes an issue where swipe-to-delete in Unified Inbox only persisted for the first message deletion during an app session.

Previously:

  • The first swipe deletion worked correctly.
  • Subsequent swipe deletions temporarily removed messages from the UI, but the messages reappeared after restarting the app.
  • Multi-select delete and swipe-delete in individual folders continued to work correctly.

Root Cause

The Unified Inbox swipe-delete flow was not correctly persisting state updates for subsequent delete operations within the same session.

Changes

  • Updated the Unified Inbox delete handling to ensure every swipe action correctly persists message deletion state.
  • Kept behavior consistent with existing delete flows used by individual folders and multi-select actions.
  • Added/updated related logic to prevent stale message state from being restored after app restart.

Testing

Tested by:

  1. Opening Unified Inbox
  2. Swiping multiple consecutive messages to delete
  3. Restarting the app
  4. Verifying all swiped messages remained deleted

Also verified:

  • Multi-select delete still works
  • Swipe-delete in individual folders still works

Fixes #10998

AI Usage Disclosure

AI assistance tools were used to help navigate the repository structure, trace relevant code paths, and assist with implementation/debugging. All code changes were reviewed and validated manually before submission.

@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown
Contributor

Validation Passed: All report and feature-flag labels are correctly set.

@wmontwe wmontwe added the report: include Include changes in user-facing reports. label May 28, 2026
@wmontwe wmontwe changed the title Fix/unified inbox swipe delete fix: unified inbox swipe delete May 28, 2026
@wmontwe

wmontwe commented Jun 10, 2026

Copy link
Copy Markdown
Member

This doesn't appear to fix #10998. Or I can't reproduce it. I think the bug is related to the rapid swipe actions not triggering deleteMessages() while animating.

I'm working on test tooling that would allow to replicate the environment easily and then come back again to check this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: include Include changes in user-facing reports.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only the first swiped message is deleted in Unified Inbox (subsequent swipes do nothing)

2 participants