fix: printed header uses US date/time format rather than the device locale#11129
Open
mohitsatr wants to merge 1 commit into
Open
fix: printed header uses US date/time format rather than the device locale#11129mohitsatr wants to merge 1 commit into
mohitsatr wants to merge 1 commit into
Conversation
Contributor
|
✅ Validation Passed: All report and feature-flag labels are correctly set. |
|
Thanks for working on this. I had also investigated #11109 locally and reached the same production fix: replacing the hardcoded I manually verified the behavior on a Motorola Edge 60 Fusion with 24-hour time enabled, using the same email in both builds:
So this confirms the fix respects local date ordering and the 24-hour time preference. I also have a small Robolectric regression test for a German region / 24-hour setup. Happy to share that patch if test coverage would be useful here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11109