Make compatible with standard pip installation methods#119
Open
jrouly wants to merge 2 commits intothunlp:masterfrom
Open
Make compatible with standard pip installation methods#119jrouly wants to merge 2 commits intothunlp:masterfrom
jrouly wants to merge 2 commits intothunlp:masterfrom
Conversation
3104bb4 to
cc9c5ae
Compare
|
until this is merged, if at all, you can use this: |
Author
|
@helloxcq @zzy14 @eustomaqua @Freyr-Wings @skeletondyh Any chance of getting this merged? We've been maintaining an internal fork with this change for over a year now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
setup.pyexists within a subfolder (src) and this package is not published on PyPi, it's impossible to install from git with package managers likepoetry.Moving
setup.pyto the top level and exposing the package instead ofsrcmakes this package more compatible.