Refactor cred_security_struct, find_task_by_vpid and strncpy_from_user_nofault.#3299
Open
shadichy wants to merge 5 commits intotiann:mainfrom
Open
Refactor cred_security_struct, find_task_by_vpid and strncpy_from_user_nofault.#3299shadichy wants to merge 5 commits intotiann:mainfrom
cred_security_struct, find_task_by_vpid and strncpy_from_user_nofault.#3299shadichy wants to merge 5 commits intotiann:mainfrom
Conversation
Define `cred_security_struct` as `task_security_struct` for kernel versions older than 6.18. This simplifies the code by removing conditional variable declarations. Signed-off-by: shadichy <shadichy@blisslabs.org>
…ID)` in place of `find_task_by_vpid` Since `find_task_by_vpid` is a non-exported symbol, but it's just a wrapper of the sequence `rcu_read_lock` -> `pid_task(find_vpid(pid), PIDTYPE_PID)` -> `rcu_read_unlock`, it's better to just call its content directly as we already wrap it in a sequence of `rcu_read_lock` and `rcu_read_unlock`. Signed-off-by: shadichy <shadichy@blisslabs.org>
hmtheboy154
reviewed
Mar 15, 2026
Collaborator
|
What's the usage of this commit? ksuinit can resolve symbol address on the fly. |
Replaces `strncpy_from_user_nofault` with a wrapper that does the same task, since it is not an exported symbol. Signed-off-by: shadichy <shadichy@blisslabs.org>
Contributor
Author
It's not just or kernelsu, but also for waydroid. Since probing on non-android linux requires something similar to ksuinit, and this creates some overhead delays on grepping symbols. |
Collaborator
|
Are these all the symbols you need for it to load without ksuinit? |
Contributor
Author
No of course, not enough. KSU uses a lot of non-exported symbols, most of them are unresolvable. These are just list of resolvable/replaceable ones. |
Signed-off-by: shadichy <shadichy@blisslabs.org>
Signed-off-by: shadichy <shadichy@blisslabs.org>
Ylarod
force-pushed
the
main
branch
4 times, most recently
from
f99db52 to
b3d034d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.