Modifiy the check condition of same hash bucket in hashmap_set#45
Open
BlueBlueMooo wants to merge 1 commit intotidwall:masterfrom
Open
Modifiy the check condition of same hash bucket in hashmap_set#45BlueBlueMooo wants to merge 1 commit intotidwall:masterfrom
BlueBlueMooo wants to merge 1 commit intotidwall:masterfrom
Conversation
Owner
|
I can't make heads of this change. What does this fix exactly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Tidwall,
I modified the if-condition in
hashmap_set_with_hashused to check new element-data is same as the bucket_item data or not.It may be better? I don't known :), just to pull a request to discuss.
Thank you.