Don't qualify * in single-table SELECTs
#1656
Open
+149
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I should find some time for reviews. I'm not very deep into R or dbplyr at the moment but it still looks familiar enough 😄 |
Member
Author
|
Oooh good memory. I'll make it optional and only enable for Oracle and teradata. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like it should be safe, since there's no ambiguity when there's only a single table, and that's what
lazy_select_queryrepresents.Fixes #1577. Fixes #1485. Fixes #1482.
@mgirlich do you have time to review a few dbplyr PRs?